Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat #879: Content embedding style #1279

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Feat #879: Content embedding style #1279

merged 2 commits into from
Aug 30, 2023

Conversation

badsketch
Copy link
Contributor

@badsketch badsketch commented Aug 30, 2023 •
edited
Loading

Addresses #879
Adds content as a type of note embedding type scope. If set, then embedding notes will not render the title.

Given z.md
Screenshot 2023-08-30 002109

And b.md
Screenshot 2023-08-30 002128

Result for content-card
full_preview

Result for content-inline

preview_inline

Appreciate any feedback!

@badsketch badsketch marked this pull request as ready for review August 30, 2023 04:25
riccardoferretti
riccardoferretti approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@riccardoferretti riccardoferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@riccardoferretti riccardoferretti merged commit eee364d into foambubble:master Aug 30, 2023
@oliver-daniel
Copy link

This is awesome! Is it documented anywhere?

@riccardoferretti
Copy link
Collaborator

https://github.com/foambubble/foam/blob/master/docs/user/features/built-in-note-embedding-types.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardoferretti riccardoferretti riccardoferretti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badsketch @oliver-daniel @riccardoferretti